Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends cqrs about goroutine pool go #18

Merged
merged 4 commits into from
May 13, 2019

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented May 12, 2019

No description provided.

@jkralik jkralik requested a review from cizmazia May 12, 2019 20:33
cqrs/eventbus/kafka/subscriber.go Show resolved Hide resolved
return fmt.Errorf("cannot force update projection: %v", err)
}
device.lock.Lock()
defer device.lock.Unlock()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider redesign to move this functionality into methods.

@codecov-io
Copy link

Codecov Report

Merging #18 into master will increase coverage by 0.99%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage    55.1%   56.09%   +0.99%     
==========================================
  Files          22       22              
  Lines         617      615       -2     
==========================================
+ Hits          340      345       +5     
+ Misses        231      225       -6     
+ Partials       46       45       -1
Impacted Files Coverage Δ
cqrs/eventbus/kafka/publisher.go 64.28% <ø> (ø) ⬆️
cqrs/eventbus/nats/publisher.go 77.77% <ø> (ø) ⬆️
cqrs/eventbus/nats/subscriber.go 0% <0%> (ø) ⬆️
cqrs/eventbus/kafka/subscriber.go 0% <0%> (ø) ⬆️
cqrs/eventstore/mongodb/eventstore.go 59.67% <100%> (ø) ⬆️
net/conn.go 76.78% <0%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d9db5...9afdabc. Read the comment docs.

@jkralik jkralik merged commit cbb344b into master May 13, 2019
@jkralik jkralik deleted the extendsCqrsAboutGoroutinePoolGo branch May 13, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants